Gottfried/glitchy-engine-beef
1
0
Fork 0
mirror of https://github.com/aharabada/glitchy-engine-beef.git synced 2026-09-05 13:01:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Kind of fixed a memory leak

Browse Source
This commit is contained in:
Simon Lübeß
2023-07-01 12:49:17 +02:00
parent 77c45db122
commit a507eeb1cd
2 changed files with 17 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
GlitchyEngine/src/Helper.bf
+10
View File
@@ -1,6 +1,7 @@
using DirectX.Common; using DirectX.Common;
using GlitchyEngine.Core; using GlitchyEngine.Core;
using System.Collections; using System.Collections;
using System;
namespace GlitchyEngine namespace GlitchyEngine
{ {
@@ -15,6 +16,15 @@ namespace GlitchyEngine
oldDest?.ReleaseRef(); oldDest?.ReleaseRef();
} }
/// Releases the reference to destination, writes newValue into it and adds a reference to newValue.
public static mixin SetReferenceVar<T>(T destination, T newValue) where T: var
{
var oldDest = destination;
destination = newValue;
destination?.AddRef();
oldDest?.Release();
}
/// Releases the reference to value and nullifies it. /// Releases the reference to value and nullifies it.
public static mixin ReleaseRefAndNullify<T>(T value) where T: RefCounter public static mixin ReleaseRefAndNullify<T>(T value) where T: RefCounter
{ {
GlitchyEngine/src/Renderer/Effect.bf
+7 -19
View File
@@ -247,7 +247,7 @@ public class Effect : Asset
{ {
Debug.Profiler.ProfileRendererFunction!(); Debug.Profiler.ProfileRendererFunction!();
[Inline]InternalSetTexture(name, textureViewBinding..AddRef()); [Inline]InternalSetTexture(name, textureViewBinding);
} }
private void InternalSetTexture(String name, TextureViewBinding textureViewBinding) private void InternalSetTexture(String name, TextureViewBinding textureViewBinding)
@@ -256,29 +256,17 @@ public class Effect : Asset
ref TextureEntry entry = ref _textures[name]; ref TextureEntry entry = ref _textures[name];
// TODO: Thats weird, we increment this reference somewhere... but WHERE?!
entry.BoundTexture.Release(); entry.BoundTexture.Release();
entry.BoundTexture = textureViewBinding; entry.BoundTexture = textureViewBinding;
entry.VsSlot?.BoundTexture..Release() = entry.BoundTexture..AddRef(); if (entry.VsSlot != null)
entry.PsSlot?.BoundTexture..Release() = entry.BoundTexture..AddRef(); SetReferenceVar!(entry.VsSlot.BoundTexture, entry.BoundTexture);
if (entry.PsSlot != null)
SetReferenceVar!(entry.PsSlot.BoundTexture, entry.BoundTexture);
} }
/*private void ApplyTextures()
{
Debug.Profiler.ProfileRendererFunction!();
for(let (name, entry) in _textures)
{
entry.VsSlot?.BoundTexture.Release();
entry.VsSlot?.BoundTexture = entry.BoundTexture;
entry.VsSlot?.BoundTexture.AddRef();
entry.PsSlot?.BoundTexture.Release();
entry.PsSlot?.BoundTexture = entry.BoundTexture;
entry.PsSlot?.BoundTexture.AddRef();
}
}*/
public void ApplyChanges() public void ApplyChanges()
{ {
Debug.Profiler.ProfileRendererFunction!(); Debug.Profiler.ProfileRendererFunction!();