Gottfried/glitchy-engine-beef
1
0
Fork 0
mirror of https://github.com/aharabada/glitchy-engine-beef.git synced 2026-09-05 13:01:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed parentTransform not causing update of child transform

Browse Source 
(also improved performance)
This commit is contained in:
Simon Lübeß
2021-09-02 12:30:18 +02:00
parent 0534824c07
commit c270fdcb03
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
GlitchyEngine/src/World/TransformSystem.bf
+15 -10
View File
@@ -9,20 +9,24 @@ namespace GlitchyEngine.World
_frame++; _frame++;
for(var entity in world.Enumerate(typeof(TransformComponent))) for(var entity in world.Enumerate(typeof(TransformComponent)))
for(var (entity, transform) in world.Enumerate<TransformComponent>())
{
UpdateEntity(entity, transform, world);
}
{ {
UpdateEntity(entity, world); UpdateEntity(entity, world);
} }
} }
private static TransformComponent* UpdateEntity(Entity entity, EcsWorld world) private static void UpdateEntity(Entity entity, TransformComponent* transform, EcsWorld world)
{ {
// Todo: this probably needs a rewrite as it may scale poorly with deep hierarchies! // Todo: this probably needs a rewrite as it may scale poorly with deep hierarchies!
var transform = world.GetComponent<TransformComponent>(entity); // transform was updated this frame -> skip
// If tranform was updated this frame -> skip
if(transform.Frame == _frame) if(transform.Frame == _frame)
return transform; return;
transform.Frame = _frame;
var parent = world.GetComponent<ParentComponent>(entity); var parent = world.GetComponent<ParentComponent>(entity);
@@ -30,7 +34,7 @@ namespace GlitchyEngine.World
{ {
transform.LocalTransform = .Translation(transform.Position) * .RotationX(transform.Rotation.X) * transform.LocalTransform = .Translation(transform.Position) * .RotationX(transform.Rotation.X) *
.RotationY(transform.Rotation.Y) * .RotationZ(transform.Rotation.Z) * .Scaling(transform.Scale); .RotationY(transform.Rotation.Y) * .RotationZ(transform.Rotation.Z) * .Scaling(transform.Scale);
transform.Frame = _frame;
transform.IsDirty = false; transform.IsDirty = false;
if(parent == null) if(parent == null)
@@ -41,17 +45,18 @@ namespace GlitchyEngine.World
if(parent != null) if(parent != null)
{ {
var parentTransform = UpdateEntity(parent.Entity, world); var parentEntity = parent.Entity;
var parentTransform = world.GetComponent<TransformComponent>(parentEntity);
UpdateEntity(parentEntity, parentTransform, world);
// TODO: I think we unnecessarily recalculate world transform every frame
// Parent transform is newer than our transform or was updated this frame // Parent transform is newer than our transform or was updated this frame
if(parentTransform.Frame >= transform.Frame) if(parentTransform.Frame >= transform.Frame)
{ {
transform.WorldTransform = parentTransform.WorldTransform * transform.LocalTransform; transform.WorldTransform = parentTransform.WorldTransform * transform.LocalTransform;
transform.Frame = parentTransform.Frame;
} }
} }
return transform;
} }
} }
} }